search

ndmitchell / nsis

Haskell DSL for producing Windows Installer using NSIS
Other
26 stars 8 forks source link

Add Unicode installer option (global) #10

Closed jmitchell closed 7 years ago

jmitchell commented 7 years ago

Give users the option to make a unicode installer. By default it's disabled because it's incompatible with older versions of Windows (see http://nsis.sourceforge.net/Docs/Chapter1.html#intro-unicode). The option itself is documented at http://nsis.sourceforge.net/Docs/Chapter4.html#aunicodetarget.

domenkozar commented 7 years ago

This targets https://github.com/ndmitchell/nsis/issues/6, should we add a note to the functions using NSIS 3? cc @ndmitchell

ndmitchell commented 7 years ago

@jmitchell - thanks for the patch!

@domenkozar - good idea!

jmitchell commented 7 years ago

@ndmitchell Certainly. Thank you for maintaining the project--it's very useful!

Regarding the note for NSIS 3 functions would you simply like a comment, an ADT specifically for them, or both? (cc: @domenkozar)

ndmitchell commented 7 years ago

Dunno - what do people suggest? One option would be to say that we expect people to be using NSIS, and call out the first few things that violate that assumption, but then very quickly just make it "the default". A static check seems overkill since we immediately compile the NSIS binary, and that will show it up pretty quickly.

domenkozar commented 7 years ago

I think nowadays anyone would just use 3.0, but best to note what's not supported there for those few unlucky devs :)

ndmitchell commented 7 years ago

Merged, and I added a small note.