search

ndmitchell / rattle

Forward build system with speculation and caching
Other
102 stars 5 forks source link

Add a flag to disable curl tests? #20

Open dhess opened 4 years ago

dhess commented 4 years ago

In nixpkgs, tests that hit the network aren't supported with Hydra builds, but there's currently no way in Rattle to disable just the curl tests, which means I have to disable all the Rattle tests for my CI runs.

It would be great if there were a flag to disable just the curl tests.

ndmitchell commented 4 years ago

Sounds very reasonable. Patch welcome, or I'll probably get to it in a few days.

dhess commented 4 years ago

I’d have submitted one myself but didn’t know how you’d like it implemented. Do you have any examples of your preferred approach?

ndmitchell commented 4 years ago

No strong preferences. A flag in https://github.com/ndmitchell/rattle/blob/master/test/Test.hs#L21 seems like it might be easiest? Just skip those tests that are network using? The simple test might need splitting into two if it does both curl and non-curl stuff - I can't remember.