don't check for hazard if cmd is speculated and we did no work

ndmitchell / rattle

Forward build system with speculation and caching

Other

102 stars 5 forks source link

don't check for hazard if cmd is speculated and we did no work #32

Closed spall closed 2 years ago

spall commented 2 years ago

Put this in it's own pull request too, to make it easier to see if its correct. In the case we do no work, check if the cmd is in the required list, and if it is call 'cmdRattleFinished' as before, otherwise do nothing.

ndmitchell commented 2 years ago

This conflicts with the previous diff, so needs rebasing over that. Does this fix the issue you described? Does it break the UI printing? Or is this the perfect and easy fix (it certainly looks nice and simple).

spall commented 2 years ago

This isn't the speculative bug fix, this is just one of the things we talked about in the meeting how it doesn't make sense to check for hazards if the command was speculated and not run.