search

ndmitchell / rattle

Forward build system with speculation and caching
Other
102 stars 5 forks source link

pass the timestamp we recorded so things will get removed from running #34

Closed spall closed 2 years ago

spall commented 2 years ago

I discovered a silly bug where commands were never recorded because nothing was ever removed from running. This is because a new starting timestamp was being passed to 'cmdRattleFinished', which wasn't the same timestamp recorded as part of the running data. So, when we try to remove the command from running the filter didn't find it.

I just wanted to get this working again so I did the simplest thing possible and just pass another timestamp. It might just be better to change how commands are removed from the running list.

ndmitchell commented 2 years ago

Thanks! Agreed there might be a better way to do it, but this approach won't be performance critical, and should solve it, so let's go with that for now.