Refactor of telegram_specifications.py and added E.ON Hungary specification

[balazs92117]

Follow up of #134

So I did the followings:

• In telegram_specifications.py:
  • I changed objects from dict to list of objects (dicts) of the following format:
  • { 'obis_reference': obis.P1_MESSAGE_HEADER, 'value_parser': CosemParser(ValueParser(str)), 'value_name': 'P1_MESSAGE_HEADER' },
  • I did this only for EON_HUNGARY and SAGEMCOM_T210_D_R as a test for this discussion.
• In obis_name_mapping.py:
  • I changed the keys of the EN from obis code references to texts, because I couldn't use multiple obis code reference for the same obis code, so it just wouldn't make sense to leave it that way.
  • Also now this whole EN dict doesn't make much sense, but in the future, if somebody wants to translate this project, (s)he could easily do that.
• I changed parsers.py to match the new list->dict format of specifications.

//TODO

1. If this refactor is ok with you @ndokter, I will change the other specifications too.
2. I would suggest to change obis_references.py from names to obis codes. So e.g.: OBIS_028 instead of P1_MESSAGE_HEADER. With this modificaitons the names wouldn't be so confusing, as a lot of specification uses the same obis code for different values (under different name). This is a very big BC, which would break e.g.: Home Assistant integration, so maybe we shouldn't do this in this PR.
3. I would merge multiple name mappings which are the same. e.g.: Q3D_EQUIPMENT_SERIALNUMBER and EON_HU_EQUIPMENT_SERIAL_NUMBER to EQUIPMENT_SERIAL_NUMBER or the lots of *EQUIPMENT_IDENTIFIERs . Just in the name mappings in EN, as the obis references are heavily used in e.g.: HA integration.

[ndokter]

It looks good, thanks for your hard work. Made 1 comment that we should maintain backwards compatibility for now

[balazs92117]

Also I would skip both 2. and 3. of the TODO list, as I have no idea what would this affect (I checked the HA integration and it is a bit confusing). So I add the new names/references with EON_HU prefix, and use the already existing ones where the name is exactly the same. See the latest commit.

[ndokter]

Ok maybe we can do the following, let me know what you think. Ill try to summarize all thoughts in this comment, so i wont clutter the PR too much:

• Keep the HU specific values with prefix
• But do rename EON_HU_ELECTRICITY_USED_TARIFF_3 = r'^\d-\d:1\.8\.3.+?\r\n' to ELECTRICITY_USED_TARIFF_1 = r'^\d-\d:1\.8\.1.+?\r\n'. Same goes for tariff 4. These are general values
  • same for delivered tariff 3 and 4
• continue with the dsmr specifications dict structure and apply it for all dsmr specifications (a lot of work..):

          {
          'obis_reference': obis.P1_MESSAGE_HEADER,
          'value_parser': CosemParser(ValueParser(str)),
          'value_name': 'P1_MESSAGE_HEADER'
      },

• delete the translation dict in obis_name_mapping.py and get the translated value directly from the dsmr specification 'value_name'

Is this possible or am i missing something? And would you want to make all the needed changes?

Nigel

[balazs92117]

Ah alright, I finally understand what you meant before. Yeah sure I can do this, and I aggree with the suggestions regarding the renames of OBIS references. Let me do it and create a new MR.