search

ndokter / dsmr_parser

Library to parse Dutch Smart Meter Requirements (DSMR) telegrams.
MIT License
112 stars 63 forks source link

Mbus alt #142

Closed dupondje closed 7 months ago

dupondje commented 11 months ago

Alternative implementation of #141

Instead of having a obis reference for each MBUS, only have 1 generic one.

This because at least the BE and the NL DSMR devices use MBUS. Therefor we make the MBUS obis reference generic, and convert the V5 telegram to use MBUS values.

Also remove BELGIUM_MAX_POWER_PER_PHASE as this was a duplicate.

Finally set self.maxDiff = None to have a full test output on some tests.

This new code can then be used in Home-Assistant to add MBUS devices.

jbouwh commented 11 months ago

@dupondje May be you can improve PR description a bit and explain why we are proposing these changes.

dupondje commented 11 months ago

@ndokter : Would be great if this can be reviewed, merged and a new release :) Then HA can be adapted to use MBUS.

dupondje commented 7 months ago

@ndokter : Don't know if you want to review it also? Otherwise I'll merge it in the coming days.

dupondje commented 6 months ago

@ndokter : this one is also merged in 1.4.0, you add it to the changelog? :)

ndokter commented 6 months ago

@dupondje oops, added it!