search

ndokter / dsmr_parser

Library to parse Dutch Smart Meter Requirements (DSMR) telegrams.
MIT License
112 stars 63 forks source link

Issue57 revisited #69

Closed lowdef closed 3 years ago

lowdef commented 3 years ago

Hi @ndokter,

Fixed the revoked solution proposed in https://github.com/ndokter/dsmr_parser/pull/57. Cherry picked those commits by @avandermeer and added modification so that it no longer breaks things. Also fixes issues reported in https://github.com/ndokter/dsmr_parser/issues/67.

Could you please create a new release?

Best Regards, @lowdef

codecov-io commented 3 years ago

Codecov Report

Merging #69 (3ddf036) into master (700cf6a) will increase coverage by 2.20%. The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   59.19%   61.40%   +2.20%     
==========================================
  Files          15       15              
  Lines         549      557       +8     
  Branches       63       66       +3     
==========================================
+ Hits          325      342      +17     
+ Misses        221      210      -11     
- Partials        3        5       +2
Impacted Files Coverage Δ
dsmr_parser/clients/protocol.py 49.33% <0.00%> (-2.06%) :arrow_down:
dsmr_parser/obis_name_mapping.py 100.00% <ø> (ø)
dsmr_parser/telegram_specifications.py 100.00% <ø> (ø)
dsmr_parser/obis_references.py 100.00% <100.00%> (ø)
dsmr_parser/parsers.py 96.07% <100.00%> (+2.20%) :arrow_up:
dsmr_parser/objects.py 68.90% <0.00%> (+8.40%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update feb0f88...3ddf036. Read the comment docs.

ndokter commented 3 years ago

Thanks for your contribution. I've merged it and released it as v0.27.

Merry christmas :)