Open MennaAshraf opened 11 years ago
@MennaAshraf in the UMLs in the condition box you should write else also, the condition in the brackets is not written correctly . Another thing is that you are writing what the controller method is doing so please check that
@MennaAshraf please tell me which tests have you added because there are many tests that appear to me that you have changed them but they aren't related to your task also please hook the issue because i cant find it
@Hoss93 which uml ? i mean which story and for the tests i changed in projects_controller_spec.rb (controller) and project_spec (model)
@MennaAshraf all the UMLs
@Hoss93 fixed it, please check.
@MennaAshraf you haven't covered all the cases so please get the gem that Omar told us about to test coverage in your tests
documentation reopened. Please refer to the comments
@mayaammar i did the documentation for the project controller (index , new , create , destroy ) and for the model project.rb.
okay @MennaAshraf then document def get_thumbnail in the project model.
@mayaammar done, please check.
doc verified @MennaAshraf
Pull request moved to #317
@Malatawy15 @Hoss93 @georgesamy @mayaammar please review my branch.
83 #84 #127