Closed ndorrh closed 2 years ago
Hello. I am done implementing the required changes. I have already summited the project for review through my dash board. Thanks for your help
On Thu, Aug 18, 2022, 10:07 AM Zain Sadaqat @.***> wrote:
@.**** commented on this pull request.
In index.html https://github.com/ndorrh/portfolio/pull/1#discussion_r948850554:
@@ -0,0 +1,57 @@ +<!DOCTYPE html> +
My Portfolio The logo should be wrapped into an tag. For Example
This is for three reasons: convention, semantics, and user experience(UX). Check this link https://ux.stackexchange.com/questions/81727/why-is-it-standard-for-a-website-logo-to-navigate-to-the-home-page for more info.
— Reply to this email directly, view it on GitHub https://github.com/ndorrh/portfolio/pull/1#pullrequestreview-1076975895, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZOWA6FWCOCTQ53T3JGGPD3VZX4N3ANCNFSM564LB4DA . You are receiving this because you were mentioned.Message ID: @.***>
My Portfolio: Mobile first
In this project: