search

ndparker / rjsmin

Fast javascript minifier for Python
http://opensource.perlig.de/rjsmin/
Apache License 2.0
60 stars 15 forks source link

Preserve `/*!`-style comment blocks #1

Closed reefdog closed 10 years ago

reefdog commented 10 years ago

A common practice for preserving necessary comment blocks in minified JavaScript output is opening the comment block with /*!. This is particularly useful for maintaining licenses.

We've had to disable JS minifying entirely on our Django-based / Heroku-hosted app, because rJSmin doesn't preserve license blocks and Closure/YUICompressor both require a Java runtime which Heroku doesn't provide.

Do you think this can be added to rJSmin?

ndparker commented 10 years ago

Yep. I put that off for a while now ;-)

It will be optional, because it will certainly slow down things a bit. So the django integration will probably need a change, too, then.

reefdog commented 10 years ago

Hey, optional's an improvement over nothing! :)

Looking forward to it.

reefdog commented 10 years ago

Thanks for your work, btw.

ndparker commented 10 years ago

Added. And included in the fresh 1.0.8 release.

reefdog commented 10 years ago

Awesome! Thanks @ndparker.