Added support for `` (tick) as a string literal

ndparker / rjsmin

Fast javascript minifier for Python

http://opensource.perlig.de/rjsmin/

Apache License 2.0

60 stars 15 forks source link

Added support for `` (tick) as a string literal #10

Closed allada closed 5 years ago

allada commented 7 years ago

This patch adds proper string support for the tick string template.

See: https://codereview.chromium.org/2229683002/

ndparker commented 7 years ago

Thanks! That was the easy part. Need to enter it to the C code and regenerate the poser regex before releasing that.

I feel the pressure now :-)

allada commented 7 years ago

How about this? Also, do you have any tests?

ndparker commented 7 years ago

Ah, wrong file, sorry. jsmin.c is the "original" one by Douglas Crockford I've got there for testing and benchmarking purposes. It's rjsmin.c in the root.

The test suite is rather sparse right now cough.

I'll have a look at rjsmin.c right now.

ndparker commented 7 years ago

Let's continue in https://github.com/ndparker/rjsmin/issues/8.

ndparker commented 5 years ago

Reworked and released in 1.1.0.