v2.3.3 not fully reflected?

sourabhxyz commented 1 year ago

Hi, my package.json file tells that I am on version 2.3.3 ("react-countdown": "^2.3.3",) but latest update to onComplete is not reflected (as it is not firing up when given date was already passed) and when I navigate to its type, I see readonly onComplete?: CountdownTimeDeltaFn | LegacyCountdownProps['onComplete']; And not

readonly onComplete?: (
    timeDelta: CountdownTimeDelta,
    completedOnStart: boolean
  ) => void | LegacyCountdownProps['onComplete'];

I installed the package via yarn.

sourabhxyz commented 1 year ago

Can see in this sandbox link.

ndresx commented 1 year ago

Hi @sourabhxyz, yes, you are correct. Many thanks for noticing and reporting this issue!

This should be fixed with the latest release https://www.npmjs.com/package/react-countdown/v/2.3.4.

ndresx / react-countdown

v2.3.3 not fully reflected? #219