nds-org / workbench-webui

Web UI for the Workbench platform
0 stars 1 forks source link

feat: add smoke test action for yarn build #11

Closed bodom0015 closed 1 year ago

bodom0015 commented 1 year ago

Problem

Upgrading to NodeJS 17+ now breaks our build:


Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/tokenize' is not defined by "exports" in /app/workbench-webui/node_modules/postcss-safe-parser/node_modules/postcss/package.json
    at new NodeError (node:internal/errors:372:5)
    at throwExportsNotFound (node:internal/modules/esm/resolve:440:9)
    at packageExportsResolve (node:internal/modules/esm/resolve:719:3)
    at resolveExports (node:internal/modules/cjs/loader:482:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:522:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/app/workbench-webui/node_modules/postcss-safe-parser/lib/safe-parser.js:1:17) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

Approach

Locally, we can use 14 or 16 but the CI tools use LTS, which is now v18

Add a set of smoke test steps to (hopefully) catch these types of errors earlier

bodom0015 commented 1 year ago

Related: https://github.com/postcss/postcss-safe-parser/issues/29