search

ndt-project / ndt

Network Diagnostic Tool
Other
178 stars 45 forks source link

Don't assume server supports all test types #216

Closed bassosimone closed 7 years ago

bassosimone commented 7 years ago

The NDT client assumes that the server supports all test types and the official NDT server respects this assumption.

However, the neubot/botticelli server only implements TEST_META, TEST_S2C, and TEST_S2C.

Therefore, when using the NDT client with a botticelli server, the client crahes in processing the results of the TEST_MID that however has not been executed.

Fix by making sure that, when processing results, we use a bitmak where only bits corresponding to tests that run are actually set.

(There is also another reason why NDT client crashes when testing with botticelli, addressed by neubot/botticelli#18.)

Problems between NDT client and botticelli reported by @nkinkade, thanks!

pboothe commented 7 years ago

Thanks for fixing up web100clt!