search

ndt-project / ndt

Network Diagnostic Tool
Other
178 stars 45 forks source link

Merge dev branch into master #219

Closed nkinkade closed 7 years ago

nkinkade commented 7 years ago

It appears that a lot of useful fixes were done on various other branches and merged into the dev branch. However, we build NDT packages from the master branch, so these fixes were not making it into recent builds.

Greg, does this change set still look sane?

gfr10598 commented 7 years ago

LGTM. I probably was waiting for you to get back from leave, and then forgot about it. Not looking in detail, as this was definitely the intention at the time. You should probably scan through it briefly though.

nkinkade commented 7 years ago

There are 21 commits in this PR, most of which I don't know the intention without read a lot of history. I'm going to just assume that they are safe to merge since they were probably all code reviewed. We can rollback any change that breaks something. :)

nkinkade commented 7 years ago

Ugh. I just realized that I erroneously made this PR against ndt-project/ndt:master instead of m-lab/ndt:master. Closing this PR, and will reopen against the right repo. Sorry for the noise.