search

ndunand / moodle-atto_morefontcolors

Modification of the fontcolor plugin allowing the Moodle admin to define colors
https://moodle.org/plugins/atto_morefontcolors
4 stars 15 forks source link

Dropdown menu width too small, with Adaptable theme #9

Closed matcho closed 4 years ago

matcho commented 8 years ago

When used with adaptable theme, the dropdown menu is broken and the color squares are hidden. The CSS rule responsible for that is: .atto_fontcolor_button .dropdown-menu { min-width: inherit; } Manually setting a min-width of 50px fixes it : .atto_fontcolor_button .dropdown-menu { min-width: 50px; } An bug was filed to Adaptable theme maintainers : https://bitbucket.org/covuni/moodle-theme_adaptable/issues/385/atto-plugins-dropdown-menus-broken

Greetings from Montpellier, Mathias

ndunand commented 8 years ago

Salut Mathias,

Thanks for the report. Does your fix also work when there are several columns in the palette, as in the attached screenshot?

screen shot 2016-03-09 at 07 19 30
matcho commented 8 years ago

Hi,

Forget the comment I just delete, I was totally out. I was mixing "fontcolor" and "morefontcolor" because the display bug affects both. Maybe I should file the bug to Atto maintainers, then ?

Anyway you're right, the fix doesn't work for the default palette. Setting min-width to "initial", "0" or any other value I tried doesn't work. Setting it to an invalid value makes it work, I don't know what should be the right value for "min-width" in such a case.

Edit: setting an invalid value works in Firebug because it invalidates the "inherit" rule, but it doesn't work to put it in a CSS stylesheet. Sorry, I really have a hard time correctly reporting bugs, today :-/ So I don't have a clue how to properly set the "min-width" to prevent incorrect inheritance. Working on it...

.atto_morefontcolors_button .dropdown-menu {
  min-width: 140px; /* ok for the default palette but doesn't fix anything */
}

Greetings, Mathias

ndunand commented 8 years ago

Hi,

OK, thanks. What if you just remove the min-width property? Invalid CSS values should just be ignored, so removing it should achieve the same result.

matcho commented 8 years ago

Removing the "min-with" property in morefontcolors/styles.css works. And it doesn't break the rendering with the default "Clean" theme. I guess it's the best way to fix the issue, although I'm puzzled by the fact that the default atto color picker (fontcolor) also suffers from the bug... I'll ask again to "Adaptable" theme maintainers if they can do anything at their level.

ndunand commented 4 years ago

Closing this as it looks old now. Feel free to reopen is you consider this should stil be solved.