Replace $CFG->prefix usages by bracket syntax

ndunand / moodle-enrol_attributes

This plugin allows users to be enrolled according to any value stored in their user profile.

https://moodle.org/plugins/enrol_attributes

18 stars 22 forks source link

Replace $CFG->prefix usages by bracket syntax #10

Closed OdyX closed 8 years ago

OdyX commented 8 years ago

This partially reverts commit a0b78bd7b3d417dcf08b218690150f0fa9301d3d.

Hi there Nicolas,

$CFG->prefix should not be hardcoded, the {bracket} syntax for tables is better.

ndunand commented 8 years ago

Right, well spotted, thanks for sharing.

s-cenni commented 8 years ago

Hi! Line 612 in the lib.php file $select .= ' RIGHT JOIN '.$CFG->prefix.'user_info_data d'.$join_id.' ON d'.$join_id.'.userid = u.id'; There is another $CFG->prefix that could be removed.