ndunand / moodle-enrol_attributes

This plugin allows users to be enrolled according to any value stored in their user profile.
https://moodle.org/plugins/enrol_attributes
18 stars 22 forks source link

The plugin does not work on win10 #23

Closed IamLuksha closed 6 years ago

IamLuksha commented 6 years ago

Hello! Plugin very cool and we like it. But there is a problem when you go from a computer to Win10 and want to write users to the course, it gives an error. In the logs it refers to 128 and 149 lines of code in the lib.hph of this plugin

image

ndunand commented 6 years ago

Hello,

Thanks for providing feedback !

I'm not sure to understand correctly, could you provide step-by-step instructions on how to reproduce this error?

IamLuksha commented 6 years ago

Hello, On win7 and Linux everything works. On win10 and MacOS does not work.

https://youtu.be/HANVPPG8ZS0

ndunand commented 6 years ago

Thank you. Can you check the browser console for JavaScript errors?

IamLuksha commented 6 years ago

image

ndunand commented 6 years ago

Alright ... what if you modify the jquery.booleanEditor.js file as follows:

screen shot 2018-08-03 at 14 07 52

does it solve the problem?

IamLuksha commented 6 years ago

Yes. now works. If more problems are found, write here. Thank you so much

ndunand commented 6 years ago

Thanks for reporting back, I'll push a new release including this fix.