search

ndunand / moodle-mod_choicegroup

Moodle "Group Choice" plugin
https://moodle.org/plugins/mod_choicegroup
35 stars 63 forks source link

Add heading title and update notifications/button #107

Closed adpe closed 6 years ago

adpe commented 6 years ago

Hello @ndunand

I wanna ask if you can merge my changes (will follow) into the official repo. In general, I think this plugin must be rewrited, because in Moodle 3.3 there are some YUI-JS errors on the developer console. The AMD procedure should be chosen here. So the plugin it's actual broken in Moodle 3.3.

It would be also nice, if the response view would like the mod_choice's one: image

And not like this: image

I'll looking with our organization, if we can help you improve this plugin. Adrian

ndunand commented 6 years ago

Hi @adpe I'd be glad to merge any improvements. The plugin indeed still uses the old YUI api and as you said should be rewritten as an AMD module. I don't think it is "broken" because still performs well in Moodle 3.3 but if you're more specific about errors thrown I'll correct these.

ndunand commented 6 years ago

Thanks @adpe . I've merged #109 – have you made any other improvements you wish to share?

adpe commented 6 years ago

Hello @ndunand

Thanks for the integration. I think atm it's fine.

Kind regards Adrian

=> Closing the issue