search

ndunand / moodle-mod_choicegroup

Moodle "Group Choice" plugin
https://moodle.org/plugins/mod_choicegroup
35 stars 63 forks source link

Fix choicegroup custom completion rule #161

Closed pavelsokolov closed 1 year ago

pavelsokolov commented 2 years ago

Completion custom rule for 'requite student to make a choice' doesn't work at least since Moodle 3.11. To fix it, choicegroup_get_coursemodule_info function needs to be implemented to register this completion rule. This solves it.

lucaboesch commented 2 years ago

Could you look into that one, @ndunand, please?

ndunand commented 2 years ago

@lucaboesch we looked at this on our end but could not reproduce consistently on our side. If you experience this issue, could you please confirm and/or provide testing steps? Thanks

lucaboesch commented 2 years ago

Thanks, Nicolas, for this remark which is already very helpful. I do not observe any case or have heard complaints, it just looked suspicious. This would really be something to be covered with automatic tests. If I got to do it I'll surely create some for mod_choicegroup. Pinging @pavelsokolov: could you add here down some precise reproduction steps, please?

Best, Luca

pavelsokolov commented 1 year ago

@lucaboesch No doubt you can't reproduce it, since you have already implemented the same fix in c952882e89ef4efc5413b5aebff8847831b824c9 :)

lucaboesch commented 1 year ago

I hope it works out for you as I did implement it. The 'definition of done' here is a bit hairy. Because what this activity aims to is that a student makes a choice of a group, and then is added to a group. So once added, wouldn't it be impossible to have the status of the activity undone to 'todo: choose a group' (trainers can do that now, rewrite a completion condition)? And if assigned to a group by other means e.g. manually, wouldn't that then eliminate the todo and set it to done automatically?

Those questions came into my mind somewhat late and I think there would be some deliberation to do.