search

ndunand / moodle-mod_choicegroup

Moodle "Group Choice" plugin
https://moodle.org/plugins/mod_choicegroup
35 stars 63 forks source link

Activity completion is automatically marked as "Completed" for all participants #177

Closed leblzhaw closed 1 year ago

leblzhaw commented 2 years ago

Hello all, Currently, in the group choice, if the completion condition is changed after the activity has been created (before a choice has been made), the activity completion is automatically marked as "Completed" for all participants.

Therefore, in a course, the group choice shows that the activity completion is already completed for everyone, even though no one has made a choice yet. I was able to reproduce this behavior in one course. However, it does not seem to affect the actual function of the group dial.

If I create a group choice, save it and then adjust the conditions for the activity completion in the settings of this group choice and save it again, the activity completion for this group choice is automatically marked as "completed" for all participants. activity_report_wrong

If I create a copy of this activity, the activity completion is not yet completed in this copy with the same definitive settings. activity_report_correct

If I change the activity completion conditions (regardless of the selected setting), the activity completion for this group choice is automatically marked "completed" for all participants:in.

This is how it should be:

--> If the group choice is set correctly from the beginning including activity completion (e.g. Show as completed when the person has made a choice.), this will work without problems. TN can make a choice and for this person afterwards the activity completion is marked as completed.

It should not be like this (column 3):

--> After changing the activity completion, without making a choice, the completion is shown as completed for all participants.

Also, if the activity completion setting is changed (after the activity is created and saved but before anyone has made a choice), the activity completion settings in the activity will be locked: activy_safe_again --> Closing settings locked: One or more people (5) have already marked this activity as completed. Changing the completion settings will clear all completion status data and could cause confusion. Therefore, the options have been locked and should not be unlocked unless absolutely necessary.

If the activity completion is subsequently unlocked and the settings reset, this may cause the activity completion to function normally again. Sometimes it takes several attempts to do this. I could not see any logic as to which setting or frequency of change would lead to the desired result. activity_safe_correct

The other github-issues were studied before. However, these all do not describe the problem.

Best regards Sascha

phish108 commented 2 years ago

Hi @ndunand

This issue appears to be triggered due to a missing check during activity completion. The activity is immediately completed for all participants after the lecturer (aka myself) has visited the page. This happens after saving the activity on creation.

Cheers

Christian.

ndunand commented 1 year ago

Hi Christian ! @phish108

Thanks to Luca we now have a fix for this. Published last week as the latest release through official channels (moodle.org)

phish108 commented 1 year ago

@lucaboesch @ndunand this is awesome! thank you