search

ndunand / moodle-mod_choicegroup

Moodle "Group Choice" plugin
https://moodle.org/plugins/mod_choicegroup
34 stars 57 forks source link

Completion conditions including Behat tests fixes #177. #178

Closed lucaboesch closed 1 year ago

lucaboesch commented 1 year ago

Dear @ndunand this fixes the completion condition issues in choicegroup and also introduces continuous integration tests. Don't be scared, lots of tests have been overruled to pass even when they would have triggered some warnings (you can see the warnings in the CI runs). Some housekeeping of the code my occur useful sometimes. I only let the tests run on Moodle 4.0 and I have only tested this for Moodle 4.0

Best, Luca

ndunand commented 1 year ago

Thank you @lucaboesch !

Indeed you are right some housekeeping of this code is long overdue.