ndunand / moodle-mod_choicegroup

Moodle "Group Choice" plugin
https://moodle.org/plugins/mod_choicegroup
35 stars 64 forks source link

Update on empty existing groupchoice options #189

Closed voegii closed 10 months ago

voegii commented 1 year ago

When

image

lucaboesch commented 1 year ago

@ndunand A lecturer encountered this as well on our place, we do try the fix https://github.com/ndunand/moodle-mod_choicegroup/pull/190 and then we'll report back.

ndunand commented 1 year ago

Thanks @lucaboesch you input will be valued. We just don't want to induce any regressions but we'll take the time to review this in the near future.

lucaboesch commented 1 year ago

Dear @ndunand I can confirm the fix works. Of course, and I know that you are aware of this, I can not stress enough on how much Behat tests do help for regression prevention.

NicoAlexH commented 10 months ago

Fixed by merging https://github.com/ndunand/moodle-mod_choicegroup/pull/190