search

ndunand / moodle-mod_choicegroup

Moodle "Group Choice" plugin
https://moodle.org/plugins/mod_choicegroup
35 stars 63 forks source link

Accessibility for Group choosing #74

Closed crazyserver closed 9 years ago

crazyserver commented 9 years ago

Hi Nicolas,

I've seen the changes from version 2.6 to 2.8 and I'm working on some accessibility changes.

I took some code from a similar plugin: https://github.com/IOC/moodle-mod_choosegroup

If you agree this changes I will continue translating the strings and editing the JS code.

Tell me what you think, the code is not ready to be merged.

Cheers,

ndunand commented 9 years ago

Hi,

Thanks for sharing this. What changes are you implementing exactly?

crazyserver commented 9 years ago

:+1: When editing the activity the choice of the groups became very confusing. I tried to write a more accessible form to choose the groups and its options. I has some work to do but you can test it to see if it seems good to you and I'll finishe it early.

ndunand commented 9 years ago

OK, I just quickly tried it out. But how do you define which groups are to be used?

crazyserver commented 9 years ago

All except those that have a 0 as limit. I can change the nolimit checkbox by a use group checkbox and then if 0 is specified then it will have no limit. In the other hand, we can use two checkboxes by group but is not a good idea...

It will need contextual help as well.

crazyserver commented 9 years ago

I've made some more changes.

Please, could you review it and tell me what do you think?

Cheers,