search

ndunand / moodle-mod_choicegroup

Moodle "Group Choice" plugin
https://moodle.org/plugins/mod_choicegroup
35 stars 63 forks source link

Avoid the need of uniqueid column by using get_recordset_sql #97

Closed gedion closed 8 years ago

gedion commented 8 years ago

because there is still a possibility that the derived column may not be unique

My colleague has convinced me that though slim, it's possible that a combination of choicegroup_options id and groups_members id may not be unique when concatenated

example: row 1 Optionid =1 memberid = 12 concat uniqueid = 112 row 2 optionid = 11 memberid = 2 concat uniqueid = 112

As you can see we end up with same rows ids that are not unique.

ndunand commented 8 years ago

Thanks !

By the way, could you have a look at #98 ? Some fatal error seems to have arisen from your first PR.