search

ndunand / moodle-qtype_matrix

Source code of https://moodle.org/plugins/qtype_matrix
2 stars 10 forks source link

Change display order (could, 2) #7

Closed isacsonk closed 10 years ago

isacsonk commented 10 years ago

Change display order.

  1. [[matrix header]](arrow pointing down and rows should be visible, like choices of MC question, when you enter the question)
  2. Created /last saved
  3. Buttons “Save changes”, “ Make a copy”, Cancel Link Remark: 1) To be consistent with the other question types, the order should be changed. 2) Since the matrix is an important part of the question, I wouldn’t hide the lines with progressive disclosure. But giving the user the possibility to hide it, like it can be done with the MC choices is a good idea, especially if the save button is placed after the matrix.
ghost commented 10 years ago

screen shot 2014-04-07 at 23 17 54 double buttons actually

isacsonk commented 10 years ago

Where did this button ("Save changes and continue editing") come from? Some of the other question types have a "copy" button, but I haven't seen this button anywhere.

tkorner commented 10 years ago

as far as I know. the copy-button only appears if you edit a question (im comparison to create a new question)

ghost commented 10 years ago

qtype-matrix is pulling a lot of javascript strings on this page. This is one of them. There's a lot of non-standard moodle code going on.

ghost commented 10 years ago

This is somewhat embarrassing, but having left this "bug" to the end, now, I don't really see how the order should be changed.

In the screenshot I posted, the save buttons appear last, after the matrix header. This is how it's intended to be, right?

isacsonk commented 10 years ago

Yes, the save buttons should appear last, after the matrix.

ghost commented 10 years ago

So this is how it has always been, at least since I first interacted with the code.

isacsonk commented 10 years ago

displayorder hmm, on live it looks like this, when you open a matrix question you have created before. I haven't testet on the testserver yet. Do we have different code on live than what you are working on? I'm a bit confused here.

ghost commented 10 years ago

Hrmm. This is an important discovery. I don't have a different code for the matrix question type (except for the changes I've made so far, of course, but they don't pertain to this discussion), but I do have a different theme and I'm also running a different version of moodle (2.7).

This might be the reason for the difference in what we see.

isacsonk commented 10 years ago

Won't because this issue is obsolete in Moodle 2.7