search

ndw / xmlcalabash1

XML Calabash, an XProc processor
http://xmlcalabash.com/
106 stars 40 forks source link

Regression of #228 - Maven repo for Restlet in published pom.xml #351

Open adamretter opened 4 weeks ago

adamretter commented 4 weeks ago

There seems to be a regression of https://github.com/ndw/xmlcalabash1/issues/228. That is to say that the Maven Repo for Restlet is no longer declared in the published pom.xml for XML Calabash 1.5.7-120. I haven't checked all versions so I am not sure when this regression was introduced.

If you add a dependency on XMLCalabash 1.5.7-120 to your Java project, e.g.:

 <dependency>
    <groupId>com.xmlcalabash</groupId>
    <artifactId>xmlcalabash</artifactId>
</dependency>

If you don't already have a locally cached copy of the Restlet dependency and you try and compile mvn compile you will get the following error:

[ERROR] Failed to execute goal on project pkg-calabash: Could not resolve dependencies for project org.expath.packaging:pkg-calabash:jar:2.0.2-SNAPSHOT: The following artifacts could not be resolved: org.restlet.jee:org.restlet:jar:2.2.2 (absent), org.restlet.jee:org.restlet.ext.fileupload:jar:2.2.2 (absent), org.restlet.jee:org.restlet.ext.slf4j:jar:2.2.2 (absent): Could not find artifact org.restlet.jee:org.restlet:jar:2.2.2 in central (https://repo.maven.apache.org/maven2) -> [Help 1]

Adding the following to the local pom.xml fixes this:

    <repositories>
        <repository>
            <id>maven-restlet</id>
            <name>Restlet repository</name>
            <url>https://maven.restlet.talend.com</url>
        </repository>
    </repositories>

However, this should not be necessary as it should really be present in the published pom.xml for XML Calabash as per: https://github.com/ndw/xmlcalabash1/commit/3510f549454a2634fe10988fe61cd6c516257a76

adamretter commented 4 weeks ago

Here is a PR that might help - https://github.com/ndw/xmlcalabash1/pull/352 Note - I haven't tested it.