ndwarshuis / CinnXP

Windows XP look for Cinnamon
GNU General Public License v3.0
156 stars 7 forks source link

revert hard coded start button and icon #24

Closed NikoKrause closed 7 years ago

NikoKrause commented 7 years ago

In your last commit you hard coded the start button and icon (https://github.com/petrucci4prez/CinnXP/commit/412cd60a6373f30e1ec272032399074bc778d6bd)

If you don't use English but another language, you don't have a chance to change the text. E.g. German has "Start" wit an uppercase first letter. Spanish: Inicio

Also the user has no chance to change the icon, if he wants to use another one.

So why this idea seems to be good, when you use English, it makes it harder for non-English speaker to use.

ndwarshuis commented 7 years ago

derp :/ I knew there was a reason I never did this until now...