search

ndwarshuis / org-sql

SQL backend for Emacs Org-Mode
GNU General Public License v3.0
97 stars 9 forks source link

add a file's title & property drawer's ID #21

Open Wonko7 opened 2 months ago

Wonko7 commented 2 months ago

This seems to do what I want, but I'll be playing with it in the next few weeks, I'll probably find bugs and update this. In no rush to merge, but I'm open for feedback.

ndwarshuis commented 2 months ago

@Wonko7 thanks for working on this. My main feedback so far is that both of the new functions are almost identical to org-sql--insert-alist-add-file-properties so it makes sense to consolidate them.

These additions would also need to be documented, which I can help with unless you also want to take a stab at that.

Wonko7 commented 2 months ago

These additions would also need to be documented, which I can help with unless you also want to take a stab at that.

I'll take a look.

also the code is unfriendly to files missing an ID, I'll push something at some undefined but hopefully soonish point in time.