search

nea / MarkdownViewerPlusPlus

A Notepad++ Plugin to view a Markdown file rendered on-the-fly
MIT License
1.17k stars 143 forks source link

Bug report: spacing between list items (unordered or ordered) breaks the Markdown rendering #132

Open xmatic opened 3 years ago

xmatic commented 3 years ago

Issue description

When creating lists (unordered or ordered), if one adds line spacing between lines, it breaks the Markdown rendering.

This is best explained via screenshots, so I'm including screenshots:

This works fine: https://imgur.com/EcYgjbh

This is broken: https://imgur.com/hMwJTPU

Screenshot

This is fine: https://imgur.com/EcYgjbh

This is broken: https://imgur.com/hMwJTPU

Environment

mullocksj commented 3 years ago

I have the exact same problem Notepad++ 7.8.4 (x64) Markdown viewer 0.8.2.25525 The HTML simply has

tags in the
  • item, which is allowed. So I guess it's just an HTML rendering issue? Is it worth trying the pull request version I see has an enhanced renderer. I have not found time yet.

    • mullocksj commented 3 years ago

    Oops! should have used preview I meant to write

    simply has \

    \

    tags in the \
  • tag which is allowed.

    • xmatic commented 3 years ago

    @mullocksj I would certainly give it a try. But I've never merged a pull-request myself. Not sure how that works. Would one fork the original project and then merge the pull request in the fork?

    mullocksj commented 3 years ago

    @xmatic Sorry I am a Github newbie. I did find how to download the source via the web interface. "Pull requests" link shows you the single pull request. Click on that to see more detail and a line near the top reads "charliedrewitt wants to merge 11 commits into nea:master from charliedrewitt:master". The "charliedrewitt:master" part is a link to a view of that branch, where there is a download button.

    Date sent: Fri, 04 Dec 2020 18:46:20 -0800 From: xmatic notifications@github.com Send reply to: nea/MarkdownViewerPlusPlus reply@reply.github.com To: nea/MarkdownViewerPlusPlus MarkdownViewerPlusPlus@noreply.github.com Copies to: mullocksj sjm@kore.co.uk, Mention mention@noreply.github.com Subject: Re: [nea/MarkdownViewerPlusPlus] Bug report: spacing between list items (unordered or ordered) breaks the Markdown rendering (#132)

    @mullocksj I would certainly give it a try. But I've never merged a pull-request myself. Not sure how that works. Would one fork the original project and then merge the pull request in the fork?

    You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

    -- Dr. S.J. Mullock http://www.kore.co.uk Kore Technology Ltd Cambridgeshire Business Park Ely, Cambs. CB7 4EA, UK Tel. (Int.+ 44) (0) 1353 653030 Fax. (Int.+ 44) (0) 1353 653031 Registered in England, No. 2643175