search

nea / MarkdownViewerPlusPlus

A Notepad++ Plugin to view a Markdown file rendered on-the-fly
MIT License
1.17k stars 143 forks source link

Fix minor errors and accessibility issues #71

Closed monoblaine closed 6 years ago

monoblaine commented 6 years ago

Hi @nea,

Thank you for this amazing plugin! A Markdown viewer directly inside Notepad++ was something I desperately wanted for years.

I'd like to fix some minor issues I've come across while using the plugin:

The menu strip and the markdown viewer overlaps

A picture is probably worth a thousand words:

Overlapped

overlapped

Expected

normal

This is fixed in 892a4a5.

Scroll bar issue

I've changed the way scroll ratio is calculated in 4e0a27d.

Reference image:

image

Credits: https://www.codeproject.com/Articles/1042516/Custom-Controls-in-Win-API-Scrolling

Enable scrolling beyond last line

I've once again changed the scroll ratio calculation in cf99196 so that the option "Enable scrolling beyond last line" does not cause weird scrollbar-sync issues.

Keep the editor focused when markdown viewer is toggled on

This is self-explanatory, I guess. (c01d3dd)

Accessibility

I rarely use the mouse while working. The options panel was using mouse click events, and that wasn't getting along with keyboard navigation. I used AfterSelect event instead. (bac9a3c)

nea commented 6 years ago

Hey @monoblaine

Thanks big time for this and I am very sorry it took so long to merge it back.

I just set everything up and created release 0.8.2 thanks to you ^^

Will update the Plugin Manager information now so that it can spread.

Again, thanks a lot for that