search

nea89o / Firmament

Hypixel SkyBlock mod for 1.20.
https://modrinth.com/mod/firmament
37 stars 4 forks source link

Improved texture rendering method by adding defaults. #23

Closed HacktheTime closed 5 months ago

HacktheTime commented 5 months ago

added default parameters to the texture rendering method in the FacingThePlayerContext class as well as storing the original color value away and restoring it after the texture rendering is completed. transparency and other values like red, green, and blue can be modified if wanted but have defaults.

nea89o commented 5 months ago

I don't think i want my code to have this. Especially since tinting textures is rather rare of a thing to do, and this just adds a lot of extra parameters (=bad). Also i have multiple texture rendering methods and i dont want to duplicate all of those parameters anyway. The extra method is fine.