neagle / gokibitz

Move-by-move comments on go games.
http://gokibitz.com
MIT License
109 stars 20 forks source link

Make GoKibitz buildable again #186

Open apetresc opened 5 years ago

apetresc commented 5 years ago

I'm attempting to build a development version of GoKibitz and finding that it's incompatible in a few ways with NodeJS 10.16.0 LTS. This PR attempts to make the smallest number of changes needed to allow GoKibitz to run cleanly with a modern Node toolchain.

This PR is not ready for merging, I'm just opening now to hopefully get some help overcoming a few hurdles.

I expect more problems to pop up after I get past the error above, but hopefully it can all be worked through šŸ˜ƒ

neagle commented 5 years ago

I feel equal measures of gratitude and guilt for seeing someone else put part of their lives into a chore that I have put off myself. Thanks! I'd be happy to jump in and provide assistance if you'd be willing to give me permission to contribute to your branch while it's in PR status.

    .form-control {
        background: {
            color: $flat-green-sea;
        }
        $width: 3px;
        border: {
            color: $flat-green-sea;
            radius: 0;
                          // (...and so on)
apetresc commented 5 years ago

My pleasure šŸ˜ƒ You should already have commit access to this branch specifically - let me know if it's not working for some reason and I can just make you a contributor on my entire fork.

neagle commented 5 years ago

The README updates are fantastic; thank you!

I tried pushing to your branch and got an error--I think you have to manually allow me to make contributions, as described here. That's only if you'd like me to help you this way--if you'd rather collaborate by just having me make suggestions here, that's fine, too.

apetresc commented 5 years ago

Yup, I had that checked since the beginning, that's why I thought it would work:

image

No big deal though, just added you as a collaborator on my fork so you can push to any branch including this one :)