search

neagle / gokibitz

Move-by-move comments on go games.
http://gokibitz.com
MIT License
109 stars 20 forks source link

Kifu image generator errors on game with placed stones and no moves #187

Open alexmitrani opened 5 years ago

alexmitrani commented 5 years ago

it is loading a header but not the kifu board position that we know and love.

thanks.

neagle commented 5 years ago

Can you send me a specific link? You can always check by pulling open a game at any move and opening the source, then searching for an og:image tag. It'll look something like this:

<meta property="og:image" content="https://gokibitz.com/api/kifu/image/ryLdcYzCN/5">

Then try viewing that URL in a separate tab: https://gokibitz.com/api/kifu/image/ryLdcYzCN/5

This example's still working, for instance. I know from last time that there's at least one uncommon board situation that breaks my parser; it wouldn't surprise me a ton if there are others.

alexmitrani commented 5 years ago

Thanks for commenting. It's this one: https://gokibitz.com/kifu/ByLiNOb0E I know it's a bit unusual because there are zero moves: I wanted to share a tsumego so people could work on it using gokibitz.

neagle commented 5 years ago

Gotcha. Yeah, this is just another case where my parser seems to choke on a situation I didn't anticipate. Not sure if I'll be able to address this soon or not, but I'm sorry for the bug!

alexmitrani commented 5 years ago

No problem, thanks for your reply. Knowing what the issue is is helpful. A workaround would be to share the whole kifu instead of just a board position in isolation.