nealmckee / penumbra

Penumbra Color Theme
MIT License
1.39k stars 29 forks source link

Feedback for vim theme needed #6

Open nealmckee opened 1 year ago

nealmckee commented 1 year ago

I’ve attached a first draft for a vim theme based on rnb (zipped because github doesn’t allow the filetype), it would be awesome if someone could test drive it before I add it to the main repository. The main issue is that rnb asks for regular and dark colours so I wasn’t sure which ones are the normally used ones. Therefore please compare what you see with the sample images in the readme (ideally also by posting screenshots).

I’ve also found this tool https://vimcolors.org/ which only takes one type of colour per hue.

To get light/dark colours I need to use those from the regular and the contrast++ version, so another open question would be whether to just do one theme or with different levels of background contrast.

A light version is sadly impossible if two colours are needed per hue.

I’d also love feedback on how good the rnb defaults are in terms of distributing the colours.

removed, see current version at the bottom

Originally posted by @nealmckee in https://github.com/nealmckee/penumbra/issues/4#issuecomment-1208447919

Draiken commented 1 year ago

I think something's not quite right. I wanted to try on my vim but this was the result: DeepinScreenshot_20220809143506

nealmckee commented 1 year ago

Thanks, looks like I messed up the background colour completely. I think this version should be better:

penumbra_dark.vim.zip

It should have the correct background colour now and uses a colour from the contrast++ palette as black, not sure how necessary that is. The exact colour for black is also debatable, could also potentially be a little less dark.

frosetrain commented 1 year ago

image I did syntax on and verified that colorscheme was set to penumbra-dark, but this still happens. :(

edwintorok commented 1 year ago

I've tried creating a (Neo)Vim theme using base16 (https://github.com/RRethy/nvim-base16.git and the styling guides at https://chriskempson.com/projects/base16/). Some of the categories don't quite align well yet: https://gist.github.com/edwintorok/6bd1fc9b7f702d462c11c061c1c53732, and I'm not quite happy with the way comments look yet, but perhaps base16 would be an easier framework to use here? At least conceptually it maps nicely to the colors used here: 8 "shades" and 8 accent colors (although there is no "brown" colors, so I used "magenta" for the 8th color).

See also here for an attempt to automatically calculate a base16 palette: https://github.com/echasnovski/mini.nvim/blob/main/doc/mini.txt#L1124-L1156, although it is based on the much older CIELCh palette, and I quite like penumbra's approach better, but it shows how to map a similar scheme to base16.

mbulat commented 1 year ago

I've got a work in progress theme for vim using the https://github.com/lifepillar/vim-colortemplate toolkit plugin.

@nealmckee Would you prefer a pull request, or just share the .vim file for review?

adamm commented 1 year ago

I've got a work in progress theme for vim using the https://github.com/lifepillar/vim-colortemplate toolkit plugin.

@nealmckee Would you prefer a pull request, or just share the .vim file for review?

Pls share your POC here. (I was about to develop the same thing, then found this thread.)

mbulat commented 1 year ago

Here's the output vim file with the colorscheme:

penumbra.vim

And here's the template I used with vim-colortemplate to create it:

penumbra.colortemplate

make sure you set colorscheme penumbra in vimrc to enable

And here's a screeshot of how it should look

Screen Shot 2022-08-30 at 9 04 51 AM
navara commented 1 year ago

penumbra.vim

I get this error when using it with Vim 8.2

image

On version 9.0, it works, but the colors are strange…

image

Both are being done via puttty connection to different linux servers. Might be a limitation of the amount of terminal colors, so I'm not that much surprised.

mbulat commented 1 year ago

Both are being done via puttty connection to different linux servers. Might be a limitation of the amount of terminal colors, so I'm not that much surprised.

I'm not surprised. There is a way for it to fall back for 8 color terms etc, but I didn't experiment with those. I'm guessing at the moment it works only with 256 and true colors.

mbulat commented 1 year ago

Okay, so with 16 or 8 color this will use the terminal colors. So you'll need a penumbra terminal theme to look okay.

I've also updated the scheme to fallback better. It's not 100%, but 256 and true color should match.

penumbra.vim

penumbra.colortemplate

halostatue commented 1 year ago

I haven’t tested these on anything except my system, but I used https://github.com/arcticlimer/djanho some time ago to play with these colours and have found them quite pleasing overall, especially penumbradark++.

penumbra-vim.zip

Ttw0626 commented 4 months ago

Hi, if you use neovim, you can add this information "Neovim: yes" in penumbra.colortemplate, the t_Co should be correctly define in neovim.