search

nealrichardson / httptest

A Test Environment for HTTP Requests in R
https://enpiar.com/r/httptest/
Other
79 stars 10 forks source link

Vignettes: adding info on relative path and encoding #31

Closed max-alletsee closed 3 years ago

max-alletsee commented 4 years ago

This expands the "Vignettes" vignette slightly to enhance the package documentation regarding specifities related to the working directory that has to be used when recording requests and requirements for the file encoding.

Both topics are currently only indirectly mentioned (working directory) or not mentioned (encoding) in the package documentation, but might be potentially helpful for other users.

Any feedback is welcome.

nealrichardson commented 3 years ago

Circling back here, apologies for the delay.

On the first point about the vignette working directory, I wonder if something like #52 would help: if there is a "vignettes" subdirectory (perhaps with a vignette .Rmd matching the name given to start_vignette), step into that, else be relative to current working dir. What do you think?

On the encoding issues, we wrestled with Windows env stuff when porting the CI to GitHub Actions in #37, so there is now more "srsly, use UTF-8 everywhere" code. Can you retry your example and see if it is still a problem?

nealrichardson commented 3 years ago

I believe #55 should have resolved this. Please reopen if you find otherwise. Thanks again for your contribution here, even though we're not merging this PR.