search

nealrichardson / httptest

A Test Environment for HTTP Requests in R
https://enpiar.com/r/httptest/
Other
79 stars 10 forks source link

GH actions + testthat 3e #36

Closed jonkeane closed 3 years ago

jonkeane commented 3 years ago

I've moved over CI to GH actions following (loosely) the r-lib/actions examples. I've left travis and appveyor for now, but those both could be dropped here too.

I could never figure out what's going on with the one test that fails on windows on actions but not appveyor. It looks like m2 — which is based on a mock recorded above — has \r\n instead of simply \n when it is played back. I tried adding in the git setting for crlf (it's still there at the top of the action) and I even tried gsubing out \r, etc. to try and get the two to match to no avail (I left the series of commits trying on a branch). I suspect there is something else funky about whitespace, and possibly encoding going on there. But for now, I've punted and only run that test on not-windows.

The 3e tests are running (both for the 2nd and 3rd edition). The 3rd edition doesn't (yet) pass, though I'm working on a branch where it does (for the most part, lots of warnings that need to be cleaned up, and making sure it can pass both 2e and 3e at the same time though that's not strictly necessary since we can choose to only test httptest with either 2e or 3e, I found with dittodb it wasn't too hard to test with both and then I have a bit more confidence I don't accidentally break something when someone is running it under 2e.) and will send those along separately.

codecov-io commented 3 years ago

Codecov Report

Merging #36 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          430       430           
=========================================
  Hits           430       430

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c28a57c...c8239c0. Read the comment docs.

nealrichardson commented 3 years ago

Thanks a lot! I'll merge this and we can take up the 3e fixes and the CRLF thing separately (I have some ideas but it will be easier to test them on top of this).

After I merge, I suggest rebasing your other branches on upstream/master.