nealrichardson commented 3 years ago

Fixes #47. You can now run tests interactively with devtools::test().

The issues were:

public() doesn't really work when you've loaded the package with pkgload::load_all() because everything is put in the global environment, so we can't test that it catches when you try to call unexported functions. One skip added.
There was a gap in the logic for the scenario where you explicitly set a redactor function but pkgload is also loaded (as a special case so that you can develop a redactor for your package interactively). This is fine when running the tests without devtools, but when you do, pkgload is on the search path so the logic was wrong (and you can't detach pkgload as one of the teardowns tried.)
Some tests were altering global state and not cleaning up, so once I got the first run of devtools::test() to pass, a second run in the same R process would fail.

I've also added a GitHub Actions job that runs the tests with devtools::test() (twice, in fact) so that we don't regress on this.

cc @maelle @jonkeane

codecov-io commented 3 years ago

Codecov Report

Merging #51 (0c2e7db) into master (96e9ea6) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #51   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          435       445   +10     
=========================================
+ Hits           435       445   +10

Impacted Files	Coverage Δ
R/find-redactor.R	`100.00% <100.00%> (ø)`
R/find-requester.R	`100.00% <100.00%> (ø)`
R/vignette.R	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96e9ea6...0c2e7db. Read the comment docs.

maelle commented 3 years ago

Awesome! Any wisdom to add to https://github.com/hadley/r-pkgs/issues/483? :slightly_smiling_face:

nealrichardson / httptest

Various fixes to interactive test running #51

Codecov Report