nealrichardson / httptest

A Test Environment for HTTP Requests in R
https://enpiar.com/r/httptest/
Other
79 stars 10 forks source link

Fix condition expectations in prevision of testthat breaking change #63

Closed lionel- closed 3 years ago

lionel- commented 3 years ago

We are planning a breaking change to the condition expectations in testthat release (see NEWS item in https://github.com/r-lib/testthat/pull/1401). This PR implements a preventive fix that works with and without the breaking change.

There is no hurry to get this fix on CRAN since we are skipping one released version of testthat before going through with the change.

codecov-commenter commented 3 years ago

Codecov Report

Merging #63 (1501750) into master (e3495fb) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          464       464           
=========================================
  Hits           464       464           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update e3495fb...1501750. Read the comment docs.

nealrichardson commented 3 years ago

Thanks a lot!

hadley commented 2 years ago

We're planning on releasing to CRAN soon, so I'd really appreciate it if you could do a release so we avoid breaking a CRAN check for your package πŸ˜„

nealrichardson commented 2 years ago

We're planning on releasing to CRAN soon, so I'd really appreciate it if you could do a release so we avoid breaking a CRAN check for your package πŸ˜„

@hadley @lionel- on CRAN now

hadley commented 2 years ago

Thanks!