search

nealrichardson / httptest

A Test Environment for HTTP Requests in R
https://enpiar.com/r/httptest/
Other
79 stars 10 forks source link

Add comment to clarify without_internet usage in an example #68

Closed ErdaradunGaztea closed 2 years ago

ErdaradunGaztea commented 2 years ago

Related to issue #67 I made earlier. Added a comment to the examples that clarifies why without_internet() was used. I thought that function was added to avoid making internet calls in examples (which was a problem when I co-submitted a certain package to CRAN); the comment should clear any possible confusion from people that skip past the title and the description straight to the examples...

ErdaradunGaztea commented 2 years ago

I added a paragraph, as promised. And, besides, noticed that you used R.Version() and then pasted the components together. I replaced this part with much simpler getRversion(); from base package as well, so no dependencies were introduced. This is a numeric_version object, so a < comparison with string will work the same as utils::compareVersion().

codecov-commenter commented 2 years ago

Codecov Report

Merging #68 (485f30e) into master (78ddf44) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          464       464           
=========================================
  Hits           464       464
Impacted Files Coverage Δ
R/expect-request.R 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 78ddf44...485f30e. Read the comment docs.