search

nealrichardson / httptest

A Test Environment for HTTP Requests in R
https://enpiar.com/r/httptest/
Other
79 stars 10 forks source link

Fix requester usage #70

Closed maelle closed 2 years ago

maelle commented 2 years ago

Fix #69

nealrichardson commented 2 years ago

Thanks a lot! Can you add a test that reproduces the issue?

nealrichardson commented 2 years ago

Also FWIW I believe this is fixed in httptest2: https://github.com/nealrichardson/httptest2/blob/main/R/capture-requests.R#L95

maelle commented 2 years ago

Will do! I'll first have to experiment with this branch for another problem I'm having (a mock file that isn't found on some OS) then I'll ping you again. Thanks for your patience.

I wish I could use httptest2 but we use a dependency that uses httr. :sweat_smile:

codecov-commenter commented 2 years ago

Codecov Report

Merging #70 (ee97fd3) into master (cb1739c) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          464       464           
=========================================
  Hits           464       464
Impacted Files Coverage Δ
R/capture-requests.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb1739c...ee97fd3. Read the comment docs.