neams-th-coe / cardinal

High-Fidelity Multiphysics
https://cardinal.cels.anl.gov/
Other
92 stars 47 forks source link

Add turbulent flow test #148

Open aprilnovak opened 3 years ago

aprilnovak commented 3 years ago

Cardinal allows turbulence to be included in the NekRS model, and it would be good to have a test that covers the use case where the scratch space is used for more than just the coupling data from MOOSE. For turbulent flows, the scratch space is often used to store a wall distance computed using the Nek5000 backend, so we should add a test to ensure that proper usage of the scratch space for this dual use is maintained.

emerzari commented 3 years ago

Excellent idea. I think the SFR pin case would be excellent for this. The results were looking really good.

On Aug 4, 2021, at 2:46 PM, April Novak @.***> wrote:



Cardinal allows turbulence to be included in the NekRS model, and it would be good to have a test that covers the use case where the scratch space is used for more than just the coupling data from MOOSE. For turbulent flows, the scratch space is often used to store a wall distance computed using the Nek5000 backend, so we should add a test to ensure that proper usage of the scratch space for this dual use is maintained.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/neams-th-coe/cardinal/issues/148, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AELXDLCI4UO22LEUAJPVVATT3GDE5ANCNFSM5BRYOFFA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

aprilnovak commented 3 years ago

That was my thought as well - I'm going to make a turbulent version of the single-pin case to keep the runtime small enough to be a test.