Closed lewisgross1296 closed 6 months ago
Did you copy-paste the function into a new input file and not realize which units it was in? Or are you saying that the OpenMC python files are incorrectly setting the helium density?
I am okay to change the units to be g/cm3 if it may be less confusing.
I copy pasted the function and used the wrong units elsewhere in my script. You used the correct units in the tutorial.
Reason
I made a simulation mistake that I think other neutronics-focused researchers could also easily make and wanted to add some documentation / change the tutorial to prevent this. Essentially, I used the
coolant_density
function incorrectly. It computes in units ofkg/m3
(normal in the MOOSE world), but we are used to doing everything ing/cm3
(OpenMC world).Design
Either add a big warning + comments or divide by 1000 in the
return
and change all units tog/cm3
in the python scripts. The coolant density function is used ingas_compact/unit_cell.py
,gas_assembly/assembly.py
, andgas_compact_multiphysics/unit_cell.py
.Impact
Prevent future errors in neutronics files based on these tutorials.
I am willing to make this PR if the community thinks it is worth changing.