neams-th-coe / cardinal

High-Fidelity Multiphysics
https://cardinal.cels.anl.gov/
Other
91 stars 45 forks source link

Fix tritium score for TallyRelativeError #844

Closed aprilnovak closed 7 months ago

aprilnovak commented 7 months ago

When we recently added the enumeration to the TallyRelativeError, I didn't notice that MultiMooseEnum get input as all caps, but MooseEnum are lower case. So we had the conversion wrong going from the tritium score H3_production because the logic was still based on the assumption the incoming field was all caps.

Also added some deprecated syntax updates in the tutorials, which are unrelated to the error fix.

aprilnovak commented 7 months ago

@meltawila fyi

moosebuild commented 7 months ago

Job Precheck on 2b2983d wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/844/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 37f16e79793cd21ab40a0dd84366eaa0fb6c26ed

moosebuild commented 7 months ago

Job Documentation on 649f397 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 7 months ago

Job Coverage on 649f397 wanted to post the following:

Coverage

37f16e #844 649f39
Total Total +/- New
Rate 93.57% 93.53% -0.04% 86.67%
Hits 7249 7248 -1 13
Misses 498 501 +3 2

Diff coverage report

Full coverage report

Warnings

This comment will be updated on new commits.