search

neams-th-coe / cardinal

High-Fidelity Multiphysics
https://cardinal.cels.anl.gov/
Other
91 stars 45 forks source link

Rename tensor mechanics module #855

Closed GiudGiud closed 7 months ago

GiudGiud commented 7 months ago

refs https://github.com/idaholab/moose/issues/25584

for the heat conduction -> heat transfer commit, I did this change: "MOOSE heat conduction" -> "MOOSE heat transfer"

if this is still too much (as you often just refer to the actual heat conduction equation, and not the module), I can narrow it down a bit, or drop the commit. it s not really a priority

moosebuild commented 7 months ago

Job Documentation on e269912 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 7 months ago

Job Coverage on e269912 wanted to post the following:

Coverage

Inconsistent report tags were found between the head and base reports. This can happen when reports are missing from either the head or the base.

Inconsistent tags: dagmc Full coverage report

This comment will be updated on new commits.

aprilnovak commented 7 months ago

Thanks @GiudGiud! I think it'd be best if the find-replace regex for MOOSE heat conduction was for "MOOSE heat conduction module" --> "MOOSE heat transfer module." As you said, most of the time the context is referring to the physics model being solved in MOOSE, and I think "MOOSE heat transfer" might be confusing b/c Nek is also solving for heat transfer.

GiudGiud commented 7 months ago

It does not look like there are any occurrence of referring to the module. A grep for heat conduction shows mostly the use we mentioned.

Removed the commit