neams-th-coe / cardinal

High-Fidelity Multiphysics
https://cardinal.cels.anl.gov/
Other
91 stars 45 forks source link

display block name in errors #861

Closed aprilnovak closed 6 months ago

aprilnovak commented 6 months ago

If a user accidentally typed in a block name which does not exist in the mesh, we used to try to convert that back to a subdomain ID before printing an error message, but this ends up giving some error code in MOOSE (665335) for the subdomain name because (of course) the block didn't exist in the first place and therefore didn't have a valid ID to begin with.

Now, we print the block name instead, for better debugging.

moosebuild commented 6 months ago

Job Documentation on c5bc330 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 6 months ago

Job Precheck on a0c162b wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/861/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 85dc18026ca27d6a109638358cdb87875dbd8606

moosebuild commented 6 months ago

Job Coverage on c5bc330 wanted to post the following:

Coverage

85dc18 #861 c5bc33
Total Total +/- New
Rate 93.56% 93.59% +0.03% 100.00%
Hits 7223 7227 +4 16
Misses 497 495 -2 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.