Change internal class names to prepare for upcoming density-only feedback

neams-th-coe / cardinal

High-Fidelity Multiphysics

https://cardinal.cels.anl.gov/

Other

91 stars 45 forks source link

Change internal class names to prepare for upcoming density-only feedback #862

Closed aprilnovak closed 6 months ago

aprilnovak commented 6 months ago

Historically, we designed the feedback into OpenMC for solids (temperature only) and fluids (temperature and density). However, the code could be cleaner and easier to understand if we also allowed density-only feedback. This PR just makes some 1:1 internal member variable name changes to remove the notion of solid vs. fluid.

moosebuild commented 6 months ago

Job Documentation on f9f8eb9 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 6 months ago

Job Coverage on f9f8eb9 wanted to post the following:

Coverage

	aa8ae9	#862 f9f8eb
	Total	Total	+/-	New
Rate	93.59%	93.61%	+0.02%	100.00%
Hits	7227	7217	-10	16
Misses	495	493	-2	0

Diff coverage report

Full coverage report

This comment will be updated on new commits.