neams-th-coe / cardinal

High-Fidelity Multiphysics
https://cardinal.cels.anl.gov/
Other
91 stars 45 forks source link

Remove table print of fractional power values. #874

Closed aprilnovak closed 5 months ago

aprilnovak commented 5 months ago

For legacy reasons, we had a table print of the fractional power values of the tallies added by Cardinal. I think the additional code complexity here is no longer worth it (this was really added mostly to help with debugging the tally coding when Cardinal was first being developed).

Arguments in favor of removing this code:

moosebuild commented 5 months ago

Job Precheck on 7c0b207 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/cardinal/docs/PRs/874/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 12a09ca18954a41367102828e150f3b14c39e5d0

moosebuild commented 5 months ago

Job Documentation on e928540 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 5 months ago

Job Coverage on e928540 wanted to post the following:

Coverage

12a09c #874 e92854
Total Total +/- New
Rate 93.67% 93.66% -0.01% 100.00%
Hits 7256 7241 -15 11
Misses 490 490 - 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.