search

neams-th-coe / cardinal

High-Fidelity Multiphysics
https://cardinal.cels.anl.gov/
Other
84 stars 39 forks source link

Explore `ignore_zeros` option for the tallies added by Cardinal #875

Open aprilnovak opened 2 months ago

aprilnovak commented 2 months ago

Reason

A new capability has been added to OpenMC, ignore_zeros (https://github.com/openmc-dev/openmc/pull/2928), which will ignore zero tally bins when applying triggers. We should expose this option through the Cardinal interface so that we can control it via the MOOSE inputs.

Design

Add ignore_zeros as an option to OpenMCCellAverageProblem that will get passed into OpenMC when we create tallies.

Impact

New feature, nice for @meltawila's fusion cases where we use mesh tallies but certain scores (e.g., tritium production) necessarily have zero values in some locations.

tjlaboss commented 2 months ago

Feature has been renamed to ignore_zeros at Paul's request

aprilnovak commented 2 months ago

Thanks for catching that! We may want to name the Cardinal accessor something like ignore_zero_tallies_for_triggers or something to make it clear what the purpose is, since this will be another parameter set in the [Problem] block where we have quite a few other params.