search

neams-th-coe / cardinal

High-Fidelity Multiphysics
https://cardinal.cels.anl.gov/
Other
91 stars 45 forks source link

sawtooth docs extra info and launch script adjustment #877

Closed lewisgross1296 closed 5 months ago

lewisgross1296 commented 5 months ago

Closes #876. Open to feedback on the docs comments/submit script.

Also, is there a reason we load cmake in the job launch script? Does the cardinal executable need cmake to execute the job? I'd think no, but I am not an expert in that department

moosebuild commented 5 months ago

Job Documentation on 6c5a819 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild commented 5 months ago

Job Coverage on 6c5a819 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

aprilnovak commented 5 months ago

I think you're right, that cmake is not needed -- can you do a quick confirmation by removing it and relaunching your job?

lewisgross1296 commented 5 months ago

Works without cmake!

moosebuild commented 5 months ago

Job Test DagMC on 6c5a819 : invalidated by @aprilnovak